Skip to content

Comments

Bug 2037856: use 'configmapsleases' based leader election#1282

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
tkashem:le-lease
Jan 14, 2022
Merged

Bug 2037856: use 'configmapsleases' based leader election#1282
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
tkashem:le-lease

Conversation

@tkashem
Copy link
Contributor

@tkashem tkashem commented Jan 11, 2022

See kubernetes/kubernetes#107454 for details on how to migrate to "leases" leader election.

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jan 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2022

@tkashem: This pull request references Bugzilla bug 2037856, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

Bug 2037856: use 'configmapsleases' based leader election

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 11, 2022
@openshift-ci openshift-ci bot requested review from deads2k, sttts and wangke19 January 11, 2022 14:38
@jsafrane jsafrane mentioned this pull request Jan 11, 2022
Merged
ravisantoshgudimetla
ravisantoshgudimetla reviewed Jan 12, 2022
View reviewed changes
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Any proof PR in a repo with tests passing?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2022
@sttts
Copy link
Contributor

sttts commented Jan 14, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravisantoshgudimetla, sttts, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2022

@tkashem: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4362aa5 into openshift:master Jan 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2022

@tkashem: All pull requests linked via external trackers have merged:

Bugzilla bug 2037856 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2037856: use 'configmapsleases' based leader election

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jsafrane added a commit to jsafrane/cluster-storage-operator that referenced this pull request Jan 17, 2022
@jsafrane
Bump library-go to get leader election updates
704f332 
Namely openshift/library-go#1282
@jsafrane jsafrane mentioned this pull request Jan 17, 2022
Merged
jsafrane added a commit to jsafrane/cluster-csi-snapshot-controller-operator that referenced this pull request Jan 17, 2022
@jsafrane
Update library-go to get leader election updates
9d5fe8e 
Namely openshift/library-go#1282
@jsafrane jsafrane mentioned this pull request Jan 17, 2022
Merged
jsafrane added a commit to jsafrane/vsphere-problem-detector that referenced this pull request Jan 17, 2022
@jsafrane
Update library-go to get leader election updates
d916d1a 
Namely, get openshift/library-go#1282
@jsafrane jsafrane mentioned this pull request Jan 17, 2022
Merged
jsafrane added a commit to jsafrane/cluster-csi-snapshot-controller-operator that referenced this pull request Jan 21, 2022
@jsafrane
Update library-go to get leader election updates
880a915 
Namely openshift/library-go#1282
jsafrane added a commit to jsafrane/cluster-csi-snapshot-controller-operator that referenced this pull request Jan 25, 2022
@jsafrane
Update library-go to get leader election updates
97e0e2e 
Namely openshift/library-go#1282
@openshift-ci openshift-ci bot mentioned this pull request Jan 25, 2022
Merged
@dgrisonnet dgrisonnet mentioned this pull request Feb 3, 2023
Closed
jsafrane added a commit to jsafrane/vsphere-problem-detector that referenced this pull request Nov 24, 2023
@jsafrane
Update library-go to get leader election updates
4ef0f83 
Namely, get openshift/library-go#1282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangke19 wangke19 Awaiting requested review from wangke19

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

1 more reviewer

@ravisantoshgudimetla ravisantoshgudimetla ravisantoshgudimetla left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ravisantoshgudimetla ravisantoshgudimetla

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tkashem @sttts @ravisantoshgudimetla @openshift-merge-robot